Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Our415 44 Fix naming conventions throughout project #268

Merged
merged 30 commits into from
Nov 15, 2024
Merged

Our415 44 Fix naming conventions throughout project #268

merged 30 commits into from
Nov 15, 2024

Conversation

adriencyberspace
Copy link
Collaborator

@adriencyberspace adriencyberspace commented Nov 13, 2024 •
edited
Loading

Ticket: Fix naming conventions throughout repo

Naming convention changes:

  • ServiceDiscoveryResults -> BrowseResultsPage
  • /search -> /SearchAndBrowse
  • SecondaryNavigationWrapper -> PageHeader, moved into /ui/Navigation
  • replace "Listing" with "Detail" in many components / directories
  • general cleanup and renaming for clarity i.e. Header -> BrowseSubheader
  • all components under /page are in this format LegalPage

@adriencyberspace adriencyberspace changed the title Our415 44 browse search naming conventions Our415 44 Fix naming conventions throughout project Nov 15, 2024
@adriencyberspace
Copy link
Collaborator Author

It was a REAL adventure to change the case of searchAndBrowse to SearchAndBrowse which is why there are so many commits and failed builds.

rosschapman
rosschapman approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@rosschapman rosschapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

@adriencyberspace adriencyberspace merged commit 5abf2a6 into main Nov 15, 2024
1 check passed
@adriencyberspace adriencyberspace deleted the our415-44-browse-search-naming branch November 15, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosschapman rosschapman rosschapman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriencyberspace @rosschapman